[PATCH] D40603: [cmake] Replace -Wall with /W4 in clang-cl options now that -Wall aliases -Weverything

[Greg Bedwell via Phabricator via llvm-commits]

gbedwell created this revision.
Herald added a subscriber: mgorny.

We noticed that our Windows selfhost build was generating *incredibly* verbose warning output (thousands and thousands of -Wc++98-compat warnings for example).  I'm pretty sure that this is down to r319116 which aliased clang-cl's -Wall to clang's -Weverything.  As we were adding -Wall to clang-cl's options in our own CMake config we ended up getting -Weverything output.

Instead, reuse the code-path for cl.exe that adds /https://reviews.llvm.org/W4 instead, which for clang-cl alises clang's "-Wall -Wextra" which matches what clang-cl's /Wall previously aliased.

This should restore the verbosity of a Windows selfhost build back to its previous levels.  I suspect that will fix the bot issues that Galina mentioned.


https://reviews.llvm.org/D40603

Files:
  cmake/modules/HandleLLVMOptions.cmake

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40603.124746.patch
Type: text/x-patch
Size: 9493 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171129/f6f5663c/attachment-0001.bin>