[PATCH] D40244: [dsymutil] Upstream getBundleInfo implementation

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere marked 5 inline comments as done.
JDevlieghere added inline comments.


================
Comment at: tools/dsymutil/CFBundle.h:5
+
+void getBundleInfo(llvm::StringRef ExePath, std::string &bundleVersionStr,
+                   std::string &bundleShortVersionStr, std::string &bundleIDStr,
----------------
aprantl wrote:
> does this only work when `__APPLE__` is set? Otherwise, this would be a better fit for Support since it might be useful for other tools, too.
On non `__APPLE__` the function returns the default ("1" and "1.0"). The advantage of keeping this here is that we only have to link dsymutil against CoreFoundation. Do you think it's worth the trade-off? 


Repository:
  rL LLVM

https://reviews.llvm.org/D40244