[PATCH] D38971: Enhance libsanitizer support for invalid-pointer-pair.

[Jakub Jelínek via Phabricator via llvm-commits]

jakubjelinek added a comment.

Phabriactor doesn't allow me to update this patch, so I've uploaded it to D40600 <https://reviews.llvm.org/D40600> instead.  If you have a way to update the diff here, please do.



================
Comment at: lib/asan/asan_descriptions.h:152
+  // as other. Descriptions can have different address within the variable
+  bool PointsInsideASameVariable(const GlobalAddressDescription &other) const;
 };
----------------
marxin wrote:
> kcc wrote:
> > naming nit pick: 
> >   points inside the same var
> > or 
> >   points inside a same var
> > ?
> > 
> > Not native speaker myself, but I think *the* is right. 
> Agree, your name is better.
The comment also has a "inside a same" when it should be "inside the same".


https://reviews.llvm.org/D38971