[PATCH] D40547: AMDGPU: Fix copying i1 value out of loop with non-uniform exit
Tony Tye via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 28 19:50:43 PST 2017
t-tye added inline comments.
================
Comment at: lib/Target/AMDGPU/Utils/AMDGPULaneDominator.cpp:70
+
+ return true;
+}
----------------
Would this return true for the CFG:
B
|
|
v
A
|
|
v
end
Since no successors of A reaches A to cause false to be returned. But no check seems to be made to ensure that A traditionally-dominates B.
https://reviews.llvm.org/D40547
More information about the llvm-commits
mailing list