[PATCH] D40202: Add opt-viewer testing

[Adam Nemet via llvm-commits]

> On Nov 28, 2017, at 5:39 PM, Davide Italiano <davide at freebsd.org> wrote:
> 
> On Tue, Nov 28, 2017 at 4:12 PM, Adam Nemet via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> 
>> On Nov 28, 2017, at 3:56 PM, Zachary Turner <zturner at google.com> wrote:
>> 
>> This is failing for me on Windows.
>> 
>> $ "C:\Python27\python.exe"
>> "D:/src/llvm-mono/llvm/tools/opt-viewer/opt-viewer.py" "-s"
>> "D:\src\llvm-mono\llvm\test\tools\opt-viewer/Inputs" "-o"
>> "D:\src\llvmbuild\clang\Debug\x86\test\tools\opt-viewer\Output\basic.test.tmp"
>> "D:\src\llvm-mono\llvm\test\tools\opt-viewer/Inputs/basic/or.yaml"
>> "--no-highlight"
>> # command stderr:
>> Traceback (most recent call last):
>>  File "D:/src/llvm-mono/llvm/tools/opt-viewer/opt-viewer.py", line 20, in
>> <module>
>>    import optrecord
>>  File "D:\src\llvm-mono\llvm\tools\opt-viewer\optrecord.py", line 30, in
>> <module>
>>    p = subprocess.Popen(['c++filt', '-n'], stdin=subprocess.PIPE,
>> stdout=subprocess.PIPE)
>>  File "C:\Python27\lib\subprocess.py", line 390, in __init__
>>    errread, errwrite)
>>  File "C:\Python27\lib\subprocess.py", line 640, in _execute_child
>>    startupinfo)
>> WindowsError: [Error 2] The system cannot find the file specified
>> 
>> error: command failed with exit status: 1
>> 
>> What is c++filt supposed to be, because I don't have it.
>> 
> 
> You can probably fallback on llvm-cxxfilt, for Itanium, and leave the
> symbol unmangled on Windows.

Yeah, I think I just add an option to override the demangler and pass in llvm-cxxfilt from the build when running the test.  The main problem was that macOS does not have llvm-cxxfilt installed.

> 
>> 
>> It’s the binutils demangler, I’ll fix it later.  Reverted in r319262.  Sorry
>> about the breakage.
>> 
>> 
>> On Mon, Nov 27, 2017 at 11:01 AM Adam Nemet via Phabricator via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>>> 
>>> This revision was automatically updated to reflect the committed changes.
>>> Closed by commit rL319073: Add opt-viewer testing (authored by anemet).
>>> 
>>> Repository:
>>>  rL LLVM
>>> 
>>> https://reviews.llvm.org/D40202
>>> 
>>> Files:
>>>  llvm/trunk/cmake/config-ix.cmake
>>>  llvm/trunk/test/lit.cfg.py
>>>  llvm/trunk/test/lit.site.cfg.py.in
>>>  llvm/trunk/test/tools/opt-viewer/Inputs/basic/or.c
>>>  llvm/trunk/test/tools/opt-viewer/Inputs/basic/or.h
>>>  llvm/trunk/test/tools/opt-viewer/Inputs/basic/or.yaml
>>>  llvm/trunk/test/tools/opt-viewer/Outputs/basic/basic_or.c.html
>>>  llvm/trunk/test/tools/opt-viewer/Outputs/basic/basic_or.h.html
>>>  llvm/trunk/test/tools/opt-viewer/Outputs/basic/index.html
>>>  llvm/trunk/test/tools/opt-viewer/Outputs/basic/style.css
>>>  llvm/trunk/test/tools/opt-viewer/basic.test
>>>  llvm/trunk/test/tools/opt-viewer/lit.local.cfg
>>> 
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>> 
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>> 
> 
> -- 
> Davide
> 
> "There are no solved problems; there are only problems that are more
> or less solved" -- Henri Poincare