[llvm] r319235 - Demote this opt remark to DEBUG.

[Davide Italiano via llvm-commits]

Thanks. This was too noisy to be useful.

On Tue, Nov 28, 2017 at 2:11 PM, Adam Nemet via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: anemet
> Date: Tue Nov 28 14:11:00 2017
> New Revision: 319235
>
> URL: http://llvm.org/viewvc/llvm-project?rev=319235&view=rev
> Log:
> Demote this opt remark to DEBUG.
>
> From a random opt-stat output:
>
> Top 10 remarks:
>   tailcallelim/tailcall          53%
>   inline/AlwaysInline            13%
>   gvn/LoadClobbered              13%
>   inline/Inlined                  8%
>   inline/TooCostly                2%
>   inline/NoDefinition             2%
>   licm/LoadWithLoopInvariantAddressInvalidated  2%
>   licm/Hoisted                    1%
>   asm-printer/InstructionCount    1%
>   prologepilog/StackSize          1%
>
> Modified:
>     llvm/trunk/lib/Transforms/Scalar/TailRecursionElimination.cpp
>     llvm/trunk/test/Transforms/TailCallElim/opt-remarks-recursion.ll
>
> Modified: llvm/trunk/lib/Transforms/Scalar/TailRecursionElimination.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/TailRecursionElimination.cpp?rev=319235&r1=319234&r2=319235&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Transforms/Scalar/TailRecursionElimination.cpp (original)
> +++ llvm/trunk/lib/Transforms/Scalar/TailRecursionElimination.cpp Tue Nov 28 14:11:00 2017
> @@ -303,10 +303,7 @@ static bool markTails(Function &F, bool
>      if (Visited[CI->getParent()] != ESCAPED) {
>        // If the escape point was part way through the block, calls after the
>        // escape point wouldn't have been put into DeferredTails.
> -      ORE->emit([&]() {
> -        return OptimizationRemark(DEBUG_TYPE, "tailcall", CI)
> -               << "marked as tail call candidate";
> -      });
> +      DEBUG(dbgs() << "Marked as tail call candidate: " << *CI << "\n");
>        CI->setTailCall();
>        Modified = true;
>      } else {
>
> Modified: llvm/trunk/test/Transforms/TailCallElim/opt-remarks-recursion.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/TailCallElim/opt-remarks-recursion.ll?rev=319235&r1=319234&r2=319235&view=diff
> ==============================================================================
> --- llvm/trunk/test/Transforms/TailCallElim/opt-remarks-recursion.ll (original)
> +++ llvm/trunk/test/Transforms/TailCallElim/opt-remarks-recursion.ll Tue Nov 28 14:11:00 2017
> @@ -1,7 +1,6 @@
>  ; RUN: opt %s -tailcallelim -pass-remarks=tailcallelim -o /dev/null 2>&1 | FileCheck %s
>  ; RUN: opt %s -o /dev/null -passes='require<opt-remark-emit>,tailcallelim' -pass-remarks=tailcallelim 2>&1 | FileCheck %s
>
> -; CHECK: /home/davide/pat.c:2:20: marked as tail call candidate
>  ; CHECK: /home/davide/pat.c:2:20: transforming tail recursion into loop
>  define i32 @fib(i32 %n) nounwind ssp {
>  entry:
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits



-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare