[PATCH] D40582: Simplify Symbol::copyFrom

[Rafael Ávila de Espíndola via Phabricator via llvm-commits]

rafael created this revision.
Herald added a subscriber: emaste.

This is only used for --wrap and I don't think these fields have a meaningful impact on that feature.


https://reviews.llvm.org/D40582

Files:
  ELF/Symbols.cpp


Index: ELF/Symbols.cpp
===================================================================
--- ELF/Symbols.cpp
+++ ELF/Symbols.cpp
@@ -138,15 +138,7 @@
 // an alias to Other. This is useful for handling some options such as
 // --wrap.
 void Symbol::copyFrom(Symbol *Other) {
-  Symbol Sym = *this;
   memcpy(this, Other, sizeof(SymbolUnion));
-
-  VersionId = Sym.VersionId;
-  IsUsedInRegularObj = Sym.IsUsedInRegularObj;
-  ExportDynamic = Sym.ExportDynamic;
-  CanInline = Sym.CanInline;
-  Traced = Sym.Traced;
-  InVersionScript = Sym.InVersionScript;
 }
 
 uint64_t Symbol::getVA(int64_t Addend) const {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40582.124645.patch
Type: text/x-patch
Size: 611 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171128/71d478f1/attachment.bin>