[lld] r319248 - Copy the visibility in copyFrom.

Rafael Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 28 15:06:10 PST 2017


Author: rafael
Date: Tue Nov 28 15:06:09 2017
New Revision: 319248

URL: http://llvm.org/viewvc/llvm-project?rev=319248&view=rev
Log:
Copy the visibility in copyFrom.

This is simpler and matches bfd's behavior on the changed test.

Modified:
    lld/trunk/ELF/Symbols.cpp
    lld/trunk/test/ELF/Inputs/wrap.s
    lld/trunk/test/ELF/wrap.s

Modified: lld/trunk/ELF/Symbols.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Symbols.cpp?rev=319248&r1=319247&r2=319248&view=diff
==============================================================================
--- lld/trunk/ELF/Symbols.cpp (original)
+++ lld/trunk/ELF/Symbols.cpp Tue Nov 28 15:06:09 2017
@@ -142,7 +142,6 @@ void Symbol::copyFrom(Symbol *Other) {
   memcpy(this, Other, sizeof(SymbolUnion));
 
   VersionId = Sym.VersionId;
-  Visibility = Sym.Visibility;
   IsUsedInRegularObj = Sym.IsUsedInRegularObj;
   ExportDynamic = Sym.ExportDynamic;
   CanInline = Sym.CanInline;

Modified: lld/trunk/test/ELF/Inputs/wrap.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/Inputs/wrap.s?rev=319248&r1=319247&r2=319248&view=diff
==============================================================================
--- lld/trunk/test/ELF/Inputs/wrap.s (original)
+++ lld/trunk/test/ELF/Inputs/wrap.s Tue Nov 28 15:06:09 2017
@@ -1,5 +1,6 @@
 .global foo
 .weak __wrap_foo
+.protected __wrap_foo
 .global __real_foo
 foo = 0x11000
 __wrap_foo = 0x11010

Modified: lld/trunk/test/ELF/wrap.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/wrap.s?rev=319248&r1=319247&r2=319248&view=diff
==============================================================================
--- lld/trunk/test/ELF/wrap.s (original)
+++ lld/trunk/test/ELF/wrap.s Tue Nov 28 15:06:09 2017
@@ -28,7 +28,9 @@
 // SYM2-NEXT: Size:
 // SYM2-NEXT: Binding: Weak
 // SYM2-NEXT: Type:    None
-// SYM2-NEXT: Other:   0
+// SYM2-NEXT: Other [
+// SYM2-NEXT:   STV_PROTECTED
+// SYM2-NEXT: ]
 // SYM3:      Name: __real_foo
 // SYM3-NEXT: Value: 0x11020
 // SYM3-NEXT: Size:




More information about the llvm-commits mailing list