[PATCH] D40244: [dsymutil] Upstream getBundleInfo implementation

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: tools/dsymutil/CFBundle.cpp:119
+                                                  std::string &expanded_path) {
+  glob_t globbuf;
+  if (glob(path, GLOB_TILDE, nullptr, &globbuf) == 0) {
----------------
Capitalize according to LLVM coding guidelines? (This applies to the entire file)


================
Comment at: tools/dsymutil/CFBundle.h:5
+
+void getBundleInfo(llvm::StringRef ExePath, std::string &bundleVersionStr,
+                   std::string &bundleShortVersionStr, std::string &bundleIDStr,
----------------
does this only work when `__APPLE__` is set? Otherwise, this would be a better fit for Support since it might be useful for other tools, too.


================
Comment at: tools/dsymutil/CFBundle.h:7
+                   std::string &bundleShortVersionStr, std::string &bundleIDStr,
+                   bool &OmitShortVersion);
----------------
Should this return a struct instead?


Repository:
  rL LLVM

https://reviews.llvm.org/D40244