[PATCH] D40558: [ELF] - Trigger error when -R <filename> is given.

[Rafael Avila de Espindola via llvm-commits]

George Rimar via Phabricator <reviews at reviews.llvm.org> writes:

> Index: ELF/Options.td
> ===================================================================
> --- ELF/Options.td
> +++ ELF/Options.td
> @@ -242,6 +242,9 @@
>  defm reproduce: Eq<"reproduce">,
>    HelpText<"Dump linker invocation and input files for debugging">;
>  
> +def R: JoinedOrSeparate<["-"], "R">, MetaVarName<"<dir>">,
> +  HelpText<"Add a DT_RUNPATH to the output">;
> +
>  defm rpath: Eq<"rpath">, HelpText<"Add a DT_RUNPATH to the output">;
>  
>  def relocatable: F<"relocatable">, HelpText<"Create relocatable object file">;
> @@ -345,7 +348,6 @@
>  def alias_pie_pic_executable: F<"pic-executable">, Alias<pie>;
>  def alias_print_map_M: Flag<["-"], "M">, Alias<print_map>;
>  def alias_relocatable_r: Flag<["-"], "r">, Alias<relocatable>;
> -def alias_rpath_R: JoinedOrSeparate<["-"], "R">, Alias<rpath>;

Why not also error on "-rpath file"? That way you can keep the alias.

Cheers,
Rafael