[PATCH] D39744: [LLD][ELF][AArch64] Add support for AArch64 range extension thunks.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 28 10:22:58 PST 2017


Peter Smith via Phabricator <reviews at reviews.llvm.org> writes:

>> It is surprising that we expected support more than 4GB of code, but if
>>  that is an aarch64 requirement, LGTM.
>
> Given that it isn't possible to build a position independent executable > 4Gb I think it would be safe to do:
>
> - Use the load-literal for all non-position independent thunks
> - Use an ADRP for position independent thunks
>
> Does that sound preferable?

I think so. Supporting something that is not used in practice is unusual
in lld.

I would even start with adrp for position dependent and switch to loads
only if we start hitting very large applications, but it is your call.

Cheers,
Rafael


More information about the llvm-commits mailing list