[PATCH] D40540: Factor out more code to Common/Args.cpp.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 28 10:18:07 PST 2017


LGTM, but I do like args::getStrings better.

Cheers,
Rafael

Peter Collingbourne via Phabricator <reviews at reviews.llvm.org> writes:

> pcc added inline comments.
>
>
> ================
> Comment at: lld/Common/Args.cpp:30
> +
> +std::vector<StringRef> args::getArgs(opt::InputArgList &Args, int Id) {
> +  std::vector<StringRef> V;
> ----------------
> Maybe `args::getStrings`?
>
>
> https://reviews.llvm.org/D40540


More information about the llvm-commits mailing list