[lld] r319169 - [ELF] Read ARM BuildAttributes section to determine supported features.
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 28 10:15:02 PST 2017
Peter Smith via llvm-commits <llvm-commits at lists.llvm.org> writes:
> template <class ELFT>
> InputSectionBase *ObjFile<ELFT>::getRelocTarget(const Elf_Shdr &Sec) {
> uint32_t Idx = Sec.sh_info;
> @@ -426,16 +470,20 @@ InputSectionBase *ObjFile<ELFT>::createI
> StringRef Name = getSectionName(Sec);
>
> switch (Sec.sh_type) {
> - case SHT_ARM_ATTRIBUTES:
> - // FIXME: ARM meta-data section. Retain the first attribute section
> - // we see. The eglibc ARM dynamic loaders require the presence of an
> - // attribute section for dlopen to work.
> - // In a full implementation we would merge all attribute sections.
> + case SHT_ARM_ATTRIBUTES: {
I just noticed this is missing a "Config->EMachine == EM_ARM" check.
Cheers,
Rafael
More information about the llvm-commits
mailing list