[PATCH] D40366: [Support][Parallel] ThreadPoolExecutor fixes for Windows

[Pavel Labath via Phabricator via llvm-commits]

labath added a comment.

In https://reviews.llvm.org/D40366#933119, @andrewng wrote:

> In https://reviews.llvm.org/D40366#933070, @zturner wrote:
>
> > I absolutely do not want to disable support for ConcRT under any circumstances unless we find that it is a completely broken library, which I highly doubt.  Even then, I would want to ask Microsoft to fix it.
> >
> > What is the exact problem you're running into?
>
>
> Hi, sorry, I thought that this would be a "private" patch. Don't worry, I do not intend to make any changes without proper review!
>
> I created this patch to see if it might help with a problem being seen on Linux, in the message thread "std::thread::detach() rarely crashes in Parallel.cpp".


I have no idea about windows, but for the linux issue, you should look into whether you're not running into https://sourceware.org/bugzilla/show_bug.cgi?id=19951. We've ran into that in LLDB, where we also spawn a ton of detached threads. If you can send me some core dumps or steps to reproduce I may be able to help you with diagnosing that. If this is indeed the same bug it is fairly easy to work around it without ditching detached threads. If you can send me a core dump or steps to reproduce I may be able to help you with diagnosing that.


https://reviews.llvm.org/D40366