[PATCH] D40343: AMDGPU: Do not combine loads/store across physreg defs

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 28 00:54:03 PST 2017


nhaehnle added inline comments.


================
Comment at: lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:359
+        // tracking physreg defs and uses. This should only affect M0 in
+        // practice.
+        return false;
----------------
arsenm wrote:
> There could also be a call instruction, and the function may modify m0 or anything else
To clarify, this means that we should bail out entirely when we encounter a call instruction, right?


https://reviews.llvm.org/D40343





More information about the llvm-commits mailing list