[PATCH] D40432: [InlineFunction] Set debug loc for call to forward varargs.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 27 15:17:02 PST 2017


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D40432#936649, @aprantl wrote:

> Superficially this looks reasonable, but could you maybe quickly explain what the transformation is doing and why this is the right location to attach?


Looks reasonable to me as is. This code really just wants to modify the call argument list in place, but it happens to do it with RAUW and it forgets the debug location currently.

Thanks for the fix!


https://reviews.llvm.org/D40432





More information about the llvm-commits mailing list