[PATCH] D40524: Handle the case of live 16-bit subregisters in X86FixupBWInsts

[Andy Kaylor via Phabricator via llvm-commits]

andrew.w.kaylor added a comment.

In https://reviews.llvm.org/D40524#936926, @MatzeB wrote:

> FWIW At a first glance this feels to me as we should have the fixes in `isLive()` instead as that seems to roughly be "LivePhysRegs::contains() with tweaks" where the LivePhysRegs::contains() would check super registers.


Yeah, that makes sense. The reason I didn't do that was that this code already had special case handling for the sub_8bit_hi subregister. I suppose a case could be made that that also should be in isLive(), but since this is the only caller of isLive() the special logic of isLive() could just as well be sunk here.

Either way, you're right that it's more distributed than it ought to be. I'll clean it up.


https://reviews.llvm.org/D40524