[PATCH] D40407: [COFF] Implement constructor priorities

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/CodeGen/TargetLoweringObjectFileImpl.cpp:535-536
     if (Priority != 65535) {
-      Name += '.';
-      Name += utostr(65535 - Priority);
+      raw_string_ostream OS(Name);
+      OS << format(".%05u", 65535 - Priority);
     }
----------------
nit: I believe you could write this as

      raw_string_ostream(Name) << format(".%05u", 65535 - Priority);


================
Comment at: lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1226-1227
+  if (Priority != 65535) {
+    raw_string_ostream OS(Name);
+    OS << format(".%05u", 65535 - Priority);
+  }
----------------
Ditto


https://reviews.llvm.org/D40407