[llvm] r319100 - Revert r319090, "COFF: Do not create SectionChunks for discarded comdat sections."

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 27 13:37:51 PST 2017


Author: pcc
Date: Mon Nov 27 13:37:51 2017
New Revision: 319100

URL: http://llvm.org/viewvc/llvm-project?rev=319100&view=rev
Log:
Revert r319090, "COFF: Do not create SectionChunks for discarded comdat sections."

Caused test failures in check-cfi on Windows.
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/20284

Modified:
    llvm/trunk/include/llvm/Object/COFF.h

Modified: llvm/trunk/include/llvm/Object/COFF.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Object/COFF.h?rev=319100&r1=319099&r2=319100&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Object/COFF.h (original)
+++ llvm/trunk/include/llvm/Object/COFF.h Mon Nov 27 13:37:51 2017
@@ -275,8 +275,6 @@ struct coff_symbol_generic {
   support::ulittle32_t Value;
 };
 
-struct coff_aux_section_definition;
-
 class COFFSymbolRef {
 public:
   COFFSymbolRef() = default;
@@ -348,18 +346,6 @@ public:
     return (getType() & 0xF0) >> COFF::SCT_COMPLEX_TYPE_SHIFT;
   }
 
-  template <typename T> const T *getAux() const {
-    return CS16 ? reinterpret_cast<const T *>(CS16 + 1)
-                : reinterpret_cast<const T *>(CS32 + 1);
-  }
-
-  const coff_aux_section_definition *getSectionDefinition() const {
-    if (!getNumberOfAuxSymbols() ||
-        getStorageClass() != COFF::IMAGE_SYM_CLASS_STATIC)
-      return nullptr;
-    return getAux<coff_aux_section_definition>();
-  }
-
   bool isAbsolute() const {
     return getSectionNumber() == -1;
   }




More information about the llvm-commits mailing list