[PATCH] D40177: performance improvements for ThunderX2 T99

[Matthias Braun via Phabricator via llvm-commits]

MatzeB requested changes to this revision.
MatzeB added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:10981-10984
+bool AArch64TargetLowering::enableAggressiveFMAFusion(EVT VT) const {
+  return Subtarget->getProcFamily() == AArch64Subtarget::ThunderX2T99 &&
+    VT.isFloatingPoint();
+}
----------------
kristof.beyls wrote:
> I get the impression that the enabling of AggressiveFMAFusion is orthogonal to the change in the pipeline model.
> If so, I think it's better to commit these separately.
> Also, I think this needs a regression test to show that this does what you want.
Please avoid `getProcFamily()` checks outside of AArch64SubtargetInfo. Use target features and transfer the logic into SubtargetInfo!


Repository:
  rL LLVM

https://reviews.llvm.org/D40177