[llvm] r318777 - [ARM] Remove pre-UAL FLDM/FSTM aliases

[Friedman, Eli via llvm-commits]

Not sure who the right contact is on the Android side; adding Stephen Hines.

In the meantime, we can hack up the source code on the bot, I guess... 
adding Pengxuan.

-Eli

On 11/23/2017 2:32 AM, Oliver Stannard wrote:
>
> Hi Eli,
>
> The instructions that are failing in the build are the ones that I 
> removed support for in this patch. They are pre-UAL syntax, and we 
> don’t support this generally, so I think the long-term solution is to 
> fix the code to use the UAL syntax instead.
>
> Do you know who I should contact in AOSP about getting that code updated?
>
> The alternative would be to revert this and keep these aliases, but 
> I’d rather not do that for the reasons discussed in 
> https://reviews.llvm.org/D39196.
>
> Oliver
>
> *From:*Friedman, Eli [mailto:efriedma at codeaurora.org]
> *Sent:* 22 November 2017 19:34
> *To:* Oliver Stannard; llvm-commits at lists.llvm.org
> *Subject:* Re: [llvm] r318777 - [ARM] Remove pre-UAL FLDM/FSTM aliases
>
> On 11/21/2017 8:20 AM, Oliver Stannard via llvm-commits wrote:
>
>     Author: olista01
>
>     Date: Tue Nov 21 08:20:25 2017
>
>     New Revision: 318777
>
>     URL:http://llvm.org/viewvc/llvm-project?rev=318777&view=rev
>
>     Log:
>
>     [ARM] Remove pre-UAL FLDM/FSTM aliases
>
>     These are pre-UAL syntax, and we don't support any other pre-UAL instructions,
>
>     with the exception of FLDMX/FSTMX, which don't have a UAL equivalent. Therefore
>
>     there's no reason to keep them or their AsmParser hacks around.
>
>     With the AsmParser hacks removed, the FLDMX and FSTMX instructions get the same
>
>     operand diagnostics as the UAL instructions.
>
>     Differential revision:https://reviews.llvm.org/D39196
>
>
> This is causing a failure on the polly AOSP buildbot 
> (http://lab.llvm.org:8011/builders/aosp-O3-polly-before-vectorizer-unprofitable/builds/336/steps/build-aosp/logs/stdio). 
> Error message:
>
>
> frameworks/av/media/libstagefright/codecs/aacenc/src/asm/ARMV7/PrePostMDCT_v7.s:31:2: 
> error: invalid instruction
>         fstmfdd   sp!, {d8 - d15}
>         ^
>
> -Eli
>
> -- 
> Employee of Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
> IMPORTANT NOTICE: The contents of this email and any attachments are 
> confidential and may also be privileged. If you are not the intended 
> recipient, please notify the sender immediately and do not disclose 
> the contents to any other person, use it for any purpose, or store or 
> copy the information in any medium. Thank you. 


-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171127/36aafe11/attachment.html>