[PATCH] D40297: [RegisterCoalescer] Add verification method to check LiveInterval Segments

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 27 11:44:17 PST 2017


MatzeB added a comment.

In https://reviews.llvm.org/D40297#936084, @qcolombet wrote:

> Hi,
>
> We already checks the liveinterval in the MachineVerifier (see MachineVerifier::checkLiveness). Could we share the logic between this one and the one in the MachineVerifier?
>
> At the very least, the MachineVerifier should call this method.
>
> Cheers,
> -Quentin


+1 We should try to avoid duplicating all the code already present in the MachineVerifier. I'd rather see us starting to refactor the MachineVerifier code to be useful outside of the MachineVerifier.

Glancing at the code, would it be possible to extract some `MachineVerifierBase` class from MachineVerifier with `foundErrors`, the various `reportXXX` functions and `verifyLiveIntervals()`?


https://reviews.llvm.org/D40297





More information about the llvm-commits mailing list