[PATCH] D40219: [CMake] Add LLVM_ENABLE_IDE option to better process sources for IDE's
Chris Bieneman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 27 10:10:45 PST 2017
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
One comment below. Otherwise LGTM.
================
Comment at: cmake/modules/LLVMProcessSources.cmake:55
llvm_check_source_file_list( ${sources} )
- if( MSVC_IDE OR XCODE )
+ if( MSVC_IDE OR XCODE OR LLVM_ENABLE_IDE )
# This adds .td and .h files to the Visual Studio solution:
----------------
lebedev.ri wrote:
> Or do we want to **rely** on `LLVM_ENABLE_IDE`?
This should just be `if(LLVM_ENABLE_IDE)` because `MSVC_IDE` and `XCODE` are checked when setting the default for that variable.
https://reviews.llvm.org/D40219
More information about the llvm-commits
mailing list