[PATCH] D40407: [COFF] Implement constructor priorities
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 27 10:06:05 PST 2017
ruiu added inline comments.
================
Comment at: lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1225-1229
+ std::string Name;
+ if (IsCtor)
+ Name = ".ctors";
+ else
+ Name = ".dtors";
----------------
Maybe `std::string Name = IsCtor ? ".ctors" : ".dtors"` is slightly more readable?
================
Comment at: test/CodeGen/X86/constructor.ll:33
; CTOR-NEXT: .quad g
+; CTOR-NEXT: .section .ctors.9980,"aGw", at progbits,v,comdat
+; CTOR-NEXT: .p2align 3
----------------
Is this correct? I thought it would be .ctors.09980.
https://reviews.llvm.org/D40407
More information about the llvm-commits
mailing list