[PATCH] D39604: [DAGCombine] Move AND nodes to multiple load leaves

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

Some minor style comments



================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:505
+                              ConstantSDNode *Mask);
+    bool BackwardsPropagateMask(SDNode *N, SelectionDAG &DAG);
 
----------------
Add comment descriptions for both of these


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:3741
+  // narrowed.
+  for (unsigned i = 0; i < N->getNumOperands(); ++i) {
+    SDNode *Op = N->getOperand(i).getNode();
----------------
```
for (unsigned i = 0, e = N->getNumOperands(); i < e; ++i) {
```


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:3742
+  for (unsigned i = 0; i < N->getNumOperands(); ++i) {
+    SDNode *Op = N->getOperand(i).getNode();
+
----------------
You should be able to use this:
```
SDValue Op = N->getOperand(i);
```

and most "Op->" can be replaced with "Op."


https://reviews.llvm.org/D39604