[PATCH] D38029: [AVR] Override ParseDirective

[Leslie Zhai via Phabricator via llvm-commits]

xiangzhai marked 13 inline comments as done.
xiangzhai added inline comments.


================
Comment at: lib/Target/AVR/MCTargetDesc/AVRMCELFStreamer.h:42
+
+  void EmitValue(const MCSymbol *Sym, unsigned SizeInBytes,
+                 SMLoc Loc = SMLoc(),
----------------
dylanmckay wrote:
> Pop an `override` qualifier on this function
I don't want to override `EmitValue`, sorry for my FunctionName misleading! 


================
Comment at: test/MC/AVR/relocations.s:108
+
+; CHECK-NEXT: R_AVR_HI8_LDI_GS
+ldi r18, hi8(gs(foo))
----------------
dylanmckay wrote:
> Nice test
Thanks :)


Repository:
  rL LLVM

https://reviews.llvm.org/D38029