[PATCH] D40317: [llvm-dwarfdump] Display DW_AT_high_pc as absolute value

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Happy to hear from Adrian and Paul if this doesn't seem like the right direction - but can be handled post-commit too.

Just the change from getHighAndLow to getHigh, I think.



================
Comment at: lib/DebugInfo/DWARF/DWARFDie.cpp:241
+    uint64_t LowPC, HighPC, Index;
+    if (Die.getLowAndHighPC(LowPC, HighPC, Index))
+      OS << format("0x%016" PRIx64, HighPC);
----------------
It seems unfortunate that this searches for the low pc when we already have the form/attribute in formValue.

What happens if a buggy DIE has two LowPCs? This might erroneously print the same one twice? (I assume DWARF supports, in general, multiple instances of the same attribute in a DIE? or is that buggy enough to have been detected earlier?)


Repository:
  rL LLVM

https://reviews.llvm.org/D40317