[PATCH] D38144: [mips][mips16] Fix asmstring of Ext and Ins instructions and mips16 JALRC and JRC

Simon Dardis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 24 07:51:16 PST 2017


sdardis added a comment.

LGTM still, just add the comment I've placed inline on commit.



================
Comment at: test/CodeGen/Mips/whitespace.ll:3
+; RUN: llc  -march=mips -mcpu=mips32r2 < %s | FileCheck %s -strict-whitespace -check-prefix=32R2
+
+ at main.L = internal unnamed_addr constant [5 x i8*] [i8* blockaddress(@main, %L1), i8* blockaddress(@main, %L2), i8* blockaddress(@main, %L3), i8* blockaddress(@main, %L4), i8* null], align 4
----------------
Add a comment to this test specifying that is testing whitespace in case someone misses the -strict-whitespace in the FileCheck invocation.


https://reviews.llvm.org/D38144





More information about the llvm-commits mailing list