[PATCH] D40402: Update clang test for llvm using FILE_FLAG_DELETE_ON_CLOSE

Rafael Ávila de Espíndola via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 23 14:01:04 PST 2017


rafael created this revision.

This completes the temporary file handling saga.


https://reviews.llvm.org/D40402

Files:
  test/Modules/signal-on-windows.m
  test/Modules/signal.m


Index: test/Modules/signal.m
===================================================================
--- test/Modules/signal.m
+++ test/Modules/signal.m
@@ -1,10 +1,10 @@
-// REQUIRES: crash-recovery
+// REQUIRES: crash-recovery && !system-windows
 // RUN: rm -rf %t
 
 // Crash building module.
 // RUN: not --crash %clang_cc1 -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -I%S/Inputs %s
 
-// The dead symlink is still around, but the underlying lock file is gone.
+// The dead lock is still around, but the temp file file is gone.
 // RUN: find %t -name "crash-*.pcm.lock" | count 1
 // RUN: find %t -name "crash-*.pcm.lock-*" | count 0
 
Index: test/Modules/signal-on-windows.m
===================================================================
--- /dev/null
+++ test/Modules/signal-on-windows.m
@@ -0,0 +1,11 @@
+// REQUIRES: crash-recovery && system-windows
+// RUN: rm -rf %t
+
+// Crash building module.
+// RUN: not --crash %clang_cc1 -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -I%S/Inputs %s
+
+// On windows we always completely delete the lock
+// RUN: find %t -name "crash-*.pcm.lock" | count 0
+// RUN: find %t -name "crash-*.pcm.lock-*" | count 0
+
+ at import crash;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40402.124112.patch
Type: text/x-patch
Size: 1202 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171123/e6b148d2/attachment.bin>


More information about the llvm-commits mailing list