[PATCH] D40333: Separate LoopTraversal and BreakFalseDeps out of ExecutionDomainFix into their own files

Marina Yatsina via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 23 08:11:48 PST 2017


myatsina marked an inline comment as done.
myatsina added inline comments.


================
Comment at: lib/CodeGen/BreakFalseDeps.cpp:60
+  // Try to coalesce live-out register units from predecessors.
+  for (MachineBasicBlock::const_pred_iterator pi = MBB->pred_begin(),
+                                              pe = MBB->pred_end();
----------------
javed.absar wrote:
> You could consider changing this to range-loop by using predecessors()
I've addressed your comment in the first patch fix (https://reviews.llvm.org/D40330).
I think this change is more appropriate there.


Repository:
  rL LLVM

https://reviews.llvm.org/D40333





More information about the llvm-commits mailing list