[PATCH] D39898: [RISCV] Add custom CC_RISCV calling convention and improved call support

Ana Pazos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 22 10:12:55 PST 2017


apazos added inline comments.


================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:491
+    if (CC_RISCV(MF.getDataLayout(), i, ArgVT, ArgVT, CCValAssign::Full,
+                 ArgFlags, CCInfo, true, IsRet)) {
+      DEBUG(dbgs() << "InputArg #" << i << " has unhandled type "
----------------
add a comment next to true to indicate the var being set


================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:502
+    const SmallVectorImpl<ISD::OutputArg> &Outs, bool IsRet,
+    CallLoweringInfo *CLI) const {
+  unsigned NumArgs = Outs.size();
----------------
CLI  argument does not seem to be used in this function.


https://reviews.llvm.org/D39898





More information about the llvm-commits mailing list