[PATCH] D40097: [Inliner][NewPM] Inline functions outside of current SCC first

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 22 10:00:09 PST 2017


davidxl added a comment.

Using heuristic like this for inline order decision is like  tossing a coin. It is very likely that doing this can hurt some  cases where inlining of inner edges are important but gets blocked.

Due to current practical limitation in the inliner such as lack of the ability to inline self recursive functions, this patch can help to workaround that limitation a little, so the patch looks fine for now, though we should not depend strongly on this inline behavior in the future.


Repository:
  rL LLVM

https://reviews.llvm.org/D40097





More information about the llvm-commits mailing list