[PATCH] D40317: [llvm-dwarfdump] Display DW_AT_high_pc as absolute value
Jonas Devlieghere via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 22 05:44:36 PST 2017
JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.
================
Comment at: test/tools/llvm-dwarfdump/X86/verify_debug_info.s:13
# CHECK-NEXT: DW_AT_low_pc [DW_FORM_addr] (0x0000000000000000)
-# CHECK-NEXT: DW_AT_high_pc [DW_FORM_data4] (0x00000016){{[[:space:]]}}
+# CHECK-NEXT: DW_AT_high_pc [DW_FORM_data4] (0x0000000000000016){{[[:space:]]}}
# CHECK-NEXT: error: Compilation unit root DIE is not a unit DIE: DW_TAG_null.
----------------
probinson wrote:
> So, the DIE that has the error gets printed with forms, but not in -show-form mode? Is that why high_pc is still displayed as 8 bytes instead of 4?
I didn't account for the fact that the form encoding was also printed in `-verbose` mode. I've updated the diff and test to make this consistent with `-show-form` mode, so that if the form is printed we get the 4-byte offset rather than the 8-byte address.
Repository:
rL LLVM
https://reviews.llvm.org/D40317
More information about the llvm-commits
mailing list