[PATCH] D40316: [mips] Set microMIPS ASE flag

[Simon Dardis via Phabricator via llvm-commits]

sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

LGTM with inline nits addressed.



================
Comment at: test/CodeGen/Mips/micromips-ase-function-attribute.ll:1
+; RUN: llc -mtriple=mips-unknown-linux -filetype=obj %s -o - | llvm-readobj  -mips-abi-flags | FileCheck --check-prefix=ASE-MICROMIPS %s
+
----------------
Three nits: break the run line over multiple lines using '\', as it's longer than 80.

You can drop the check-prefix here and just use 'CHECK:'.

Also, match the 'ASEs [' and the closing ']'


================
Comment at: test/MC/Mips/micromips-ase-directive.s:1
+# RUN: llvm-mc -triple=mips-unknown-linux -filetype=obj %s -o - | llvm-readobj  -mips-abi-flags | FileCheck --check-prefix=ASE-MICROMIPS %s
+
----------------
Same here.


Repository:
  rL LLVM

https://reviews.llvm.org/D40316