[PATCH] D39595: [DAGCombine] Refactor ReduceLoadWidth

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 22 02:19:11 PST 2017


samparker added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:8026
+                            LN0->getChain(), LN0->getBasePtr(), ExtVT,
+                            LN0->getMemOperand());
   }
----------------
efriedma wrote:
> Could this block of code be simplified?  As long as you set ExtType and ExtVT correctly, I think the rest of the checks already exist in some form, by analogy to the transforms for ISD::SIGN_EXTEND_IN_REG.
Thanks Eli, indeed most of the checks that performed again.


https://reviews.llvm.org/D39595





More information about the llvm-commits mailing list