[PATCH] D39933: Summary: Fix out-of-order stepping behavior in programs with sunk instructions

[Matthew Voss via Phabricator via llvm-commits]

ormris added inline comments.


================
Comment at: llvm/trunk/lib/CodeGen/MachineSink.cpp:874
+  // and debuggers.
+  if (!SuccToSinkTo->empty()) {
+    MI.setDebugLoc(DILocation::getMergedLocation(MI.getDebugLoc(),
----------------
echristo wrote:
> We don't put braces around single statement if conditions.  Should probably also update the comments (in a follow-up comment) for the debug value moving to be clear what's going on there versus the location.
Will do.


Repository:
  rL LLVM

https://reviews.llvm.org/D39933