[PATCH] D40286: [ARM] Use SEH exception handling on MS

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 21 02:07:02 PST 2017


mstorsjo added a comment.

In https://reviews.llvm.org/D40286#931319, @martell wrote:

> Is SEH implemented for aarch64 because if not then I would prefer setting SEH here like we do for aarch64?


No, it isn't. So if you try to compile code in msvc mode that uses exceptions, it'll fail due to unimplemented codepaths. It was set/enabled on aarch64 as a side effect in SVN r308665 (git mirror commit 8c714df517f9a42f5b360b2a2ca619facd961b40).

But consistency obviously is nice, and this is what would need to be implemented for exceptions for msvc mode for arm in any case, so I don't mind setting it - the failures make it much clearer that the exceptions actually don't work yet.


Repository:
  rL LLVM

https://reviews.llvm.org/D40286





More information about the llvm-commits mailing list