[PATCH] D39849: [RISCV] Implement prolog and epilog insertion

[Ondrej Glasnak via Phabricator via llvm-commits]

glasnak added inline comments.


================
Comment at: lib/Target/RISCV/RISCVFrameLowering.cpp:31
+  // Get the number of bytes to allocate from the FrameInfo.
+  unsigned FrameSize = MFI.getStackSize();
+
----------------
shouldn't this be uint64_t?

(also not sure about MaxCallFrameSize below, as alignTo() returns uint64_t. It gets two unsigned ints, so I'll leave that up to you if it's necessary to change just to satisfy linters)


================
Comment at: lib/Target/RISCV/RISCVFrameLowering.cpp:170
+  SavedRegs.set(RISCV::X8);
+  return;
+}
----------------
redundant return?


https://reviews.llvm.org/D39849