[PATCH] D29938: [RISCV 16/n] Support and tests for a variety of additional LLVM IR constructs

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 21 00:12:50 PST 2017


asb added inline comments.


================
Comment at: test/CodeGen/RISCV/bswap-ctlz-cttz-ctpop.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=riscv32 -verify-machineinstrs < %s \
+; RUN:   | FileCheck %s -check-prefix=RV32I
----------------
apazos wrote:
> Is the 'I'  ISA always going to be the only default extension?
> I ask because some tests below have soft calls for multiplication and the checks will fail if 'IM' ISA becomes part of the default extensions.
We could change LLVM to default to a more featureful RISC-V ISA string, but it's probably helpful to have tests like this that would pick up such a change if it happens unintentionally.


Repository:
  rL LLVM

https://reviews.llvm.org/D29938





More information about the llvm-commits mailing list