[PATCH] D40240: Garbage-collected symbols shouldn't make DSOs alive.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 20 23:55:28 PST 2017


This patch is a demonstration what I was thinking when I was reviewing
Igor's patch, so feel free to take it. I could finish this if you want, but
it'd probably be easier for you to do that yourself.

On Tue, Nov 21, 2017 at 4:34 AM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> One more thing:
>
> >-      if (!S->isWeak())
> >-        File->IsUsed = true;
> >+      if (!Config->GcSections && !S->isWeak())
> >+        File->IsNeeded = true;
>
> Please leave the GcSections check for the next patch. That way this
> patch is just a cleanup on how we compute IsNeeded.
>
> It is probably OK with that, but pleas upload an updated version for a
> final check.
>
> Thanks,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171121/f81df057/attachment.html>


More information about the llvm-commits mailing list