[PATCH] D40098: [AMDGPU] Improve hazard checks for inline asm statements
Mark Searles via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 20 17:36:55 PST 2017
msearles marked an inline comment as done.
msearles added inline comments.
================
Comment at: lib/Target/AMDGPU/GCNHazardRecognizer.cpp:577
+ if (Op.isReg() && Op.isDef()) {
+ WaitStatesNeeded = std::max(WaitStatesNeeded, checkVALUHazardsHelper(Op, MRI));
+ }
----------------
arsenm wrote:
> Should this check every instruction type hazard?
Probably. I'm fine to add a FIXME to checkInlineAsmHazards() to not forget that more work needs to be done and fine to do that work. However, I'd like to push the fix for this bug, since it is being hit and add the additional code in a follow-on patch.
https://reviews.llvm.org/D40098
More information about the llvm-commits
mailing list