Re: [PATCH] D39567: [lit] Implement non-pipelined ‘mkdir’, ‘diff’ and ‘rm’ commands internally

[Ying Yi via llvm-commits]

Hi Zachary,

Sorry just see your email. I have updated the internal diff shell command
to support the --strip-trailing-cr option.  The option might be useful for
comparing the files which are generated on the different platform. Could
you please let me know what do you think?


Regards,


Maggie

On Tue, Nov 21, 2017 at 12:23 AM, Ying Yi via Phabricator <
reviews at reviews.llvm.org> wrote:

> MaggieYi updated this revision to Diff 123687.
> MaggieYi added a comment.
>
> The test of MC/AsmParser/preserve-comments-crlf.s failed since it uses
> the unsupported diff option --strip-trailing-cr. I updated the internal
> diff shell command to support this option.
>
>
> https://reviews.llvm.org/D39567
>
> Files:
>   utils/lit/lit/TestRunner.py
>   utils/lit/tests/Inputs/shtest-shell/check_path.py
>   utils/lit/tests/Inputs/shtest-shell/diff-error-0.txt
>   utils/lit/tests/Inputs/shtest-shell/diff-error-1.txt
>   utils/lit/tests/Inputs/shtest-shell/diff-error-2.txt
>   utils/lit/tests/Inputs/shtest-shell/diff-error-3.txt
>   utils/lit/tests/Inputs/shtest-shell/diff-error-4.txt
>   utils/lit/tests/Inputs/shtest-shell/diff-error-5.txt
>   utils/lit/tests/Inputs/shtest-shell/diff-error-6.txt
>   utils/lit/tests/Inputs/shtest-shell/mkdir-error-0.txt
>   utils/lit/tests/Inputs/shtest-shell/mkdir-error-1.txt
>   utils/lit/tests/Inputs/shtest-shell/mkdir-error-2.txt
>   utils/lit/tests/Inputs/shtest-shell/rm-error-0.txt
>   utils/lit/tests/Inputs/shtest-shell/rm-error-1.txt
>   utils/lit/tests/Inputs/shtest-shell/rm-error-2.txt
>   utils/lit/tests/Inputs/shtest-shell/rm-error-3.txt
>   utils/lit/tests/Inputs/shtest-shell/valid-shell.txt
>   utils/lit/tests/max-failures.py
>   utils/lit/tests/shtest-shell.py
>
>


-- 
Ying Yi
SN Systems - Sony Interactive Entertainment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171121/979502e8/attachment.html>