[PATCH] D40271: Split rename_handle out of rename on windows

[Rafael Ávila de Espíndola via Phabricator via llvm-commits]

rafael created this revision.

I want to use rename_handle in TempFile.


https://reviews.llvm.org/D40271

Files:
  lib/Support/Windows/Path.inc


Index: lib/Support/Windows/Path.inc
===================================================================
--- lib/Support/Windows/Path.inc
+++ lib/Support/Windows/Path.inc
@@ -418,14 +418,13 @@
   return std::error_code();
 }
 
+static std::error_code rename_handle(HANDLE Handle, const Twine &To);
+
 std::error_code rename(const Twine &From, const Twine &To) {
   // Convert to utf-16.
   SmallVector<wchar_t, 128> WideFrom;
-  SmallVector<wchar_t, 128> WideTo;
   if (std::error_code EC = widenPath(From, WideFrom))
     return EC;
-  if (std::error_code EC = widenPath(To, WideTo))
-    return EC;
 
   ScopedFileHandle FromHandle;
   // Retry this a few times to defeat badly behaved file system scanners.
@@ -442,6 +441,14 @@
   if (!FromHandle)
     return mapWindowsError(GetLastError());
 
+  return rename_handle(FromHandle, To);
+}
+
+static std::error_code rename_handle(HANDLE FromHandle, const Twine &To) {
+  SmallVector<wchar_t, 128> WideTo;
+  if (std::error_code EC = widenPath(To, WideTo))
+    return EC;
+
   // We normally expect this loop to succeed after a few iterations. If it
   // requires more than 200 tries, it's more likely that the failures are due to
   // a true error, so stop trying.
@@ -452,6 +459,9 @@
         std::error_code(ERROR_CALL_NOT_IMPLEMENTED, std::system_category())) {
       // Wine doesn't support SetFileInformationByHandle in rename_internal.
       // Fall back to MoveFileEx.
+      SmallVector<wchar_t, MAX_PATH> WideFrom;
+      if (std::error_code EC2 = realPathFromHandle(FromHandle, WideFrom))
+        return EC2;
       if (::MoveFileExW(WideFrom.begin(), WideTo.begin(),
                         MOVEFILE_REPLACE_EXISTING))
         return std::error_code();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40271.123667.patch
Type: text/x-patch
Size: 1723 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171120/5a1b22fd/attachment.bin>