[PATCH] D40205: [msan] Don't sanitize "nosanitize" instructions

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 20 12:52:06 PST 2017


eugenis added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:1344
   // ------------------- Visitors.
+  using InstVisitor<MemorySanitizerVisitor>::visit;
+  void visit(Instruction &I) {
----------------
what's the point of this using statement?

I think it would be more readable to do this in runOnFunction (see the depth_first loop over basic blocks).


https://reviews.llvm.org/D40205





More information about the llvm-commits mailing list