[PATCH] D39421: [InstCombine] Extracting common and-mask for shift operands of Or instruction

[Zvi Rackover via Phabricator via llvm-commits]

zvi added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:2237
+    // match (V&C1)<<C2
+    auto MatchShiftOfAnd = [](Value *V, Value *&Source,
+                              Instruction::BinaryOps &ShiftOpcode,
----------------
May be a nitpick of mine, but i would find it easier to follow these helpers if the argument and variable names would match the comments. E.g.  Source -> V, ShifyBy -> C2, PreShiftMask ->C1 ...


https://reviews.llvm.org/D39421