[PATCH] D40148: [AMDGPU] Fix DAGTypeLegalizer::SplitInteger for shift amount type

[Yaxun Liu via Phabricator via llvm-commits]

yaxunl added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.h:669
+    MVT getScalarShiftAmountTy(const DataLayout &, EVT VT) const override {
+      return VT.getSizeInBits() >= 512 ? MVT::i16 : MVT::i8;
     }
----------------
RKSimon wrote:
> Please can you put in an assert to check that the return type is big enough to hold the max shift value for VT.
Will do. Thanks.


https://reviews.llvm.org/D40148