Re: [PATCH] D39567: [lit] Implement non-pipelined ‘mkdir’, ‘diff’ and ‘rm’ commands internally

[Zachary Turner via llvm-commits]

It might be possible to re-write the test to pipe the input files through
sed to get rid of CRLF first.  We don't want to get into the business of
supporting every obscure option out there.

On Mon, Nov 20, 2017 at 8:15 AM Ying Yi <maggieyi666 at gmail.com> wrote:

> Hi Zachary and Reid,
>
>
>
> Many thanks for your code review. When I test my patch with the latest
> LLVM and Clang today, there is a new added test
> (MC/AsmParser/preserve-comments-crlf.s) which failed since it uses the
> unsupported diff option --strip-trailing-cr. I need to update the patch to
> support the diff --strip-trailing-cr option. I am working on this.
>
> Thanks,
>
> Maggie
>
> On Fri, Nov 17, 2017 at 9:37 PM, Reid Kleckner via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> rnk accepted this revision.
>> rnk added a comment.
>>
>> lgtm
>>
>>
>> https://reviews.llvm.org/D39567
>>
>>
>>
>>
>
>
> --
> Ying Yi
> SN Systems - Sony Interactive Entertainment
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171120/48468a35/attachment.html>