[PATCH] D38790: [ELF] Do not keep symbols if they referenced only from discarded sections.

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 20 08:07:05 PST 2017


ikudrin added a comment.

In https://reviews.llvm.org/D38790#930021, @ruiu wrote:

> I feel like this patch is a bit too complicated, but I can't really point out why I felt like that. This patch actually does two different things, no? Do you mind if I ask you to split it? I think one patch can be something like this https://reviews.llvm.org/D40240, and you can create another patch not to add dead symbols to the symbol table later.


The main reason I did it that way is that `ELF/gc-sections-shared.s` test stated that an external symbol `bar2` and DT_NEEDED entry for the corresponding library should be both eighter preserved or dropped. Thus, if dealing with DT_NEEDED is extracted into a separate patch, the test has to be adjusted to that intermediate state accordingly.


https://reviews.llvm.org/D38790





More information about the llvm-commits mailing list