[PATCH] D40243: Handle NetBSD specific indirection of libpthread functions

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 20 06:27:32 PST 2017


krytarowski added inline comments.


================
Comment at: lib/tsan/rtl/tsan_interceptors.cc:2480
+// NetBSD uses indirection for old threading functions for historical reasons
+TSAN_INTERCEPTOR(void, __libc_cond_init, void *c, void *a) \
+  ALIAS(WRAPPER_NAME(pthread_cond_init));
----------------
dvyukov wrote:
> Perhaps we need some helper macro so this can be spelled along the lines of:
> ```
> NETBSD_ALIAS(cond_init);
> ```
> I think we could declare all alias functions as taking no arguments.
Done. I've decided to keep arguments.


Repository:
  rL LLVM

https://reviews.llvm.org/D40243





More information about the llvm-commits mailing list