[PATCH] D40223: [X86] Control-Flow Enforcement Technology - Shadow Stack support (LLVM side)

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Support/Host.cpp:1251
   Features["sha"] = HasLeaf7 && ((EBX >> 29) & 1);
+  Features["shstk"] = HasLeaf7 && ((ECX >> 7) & 1);
+  Features["ibt"] = HasLeaf7 && ((EDX >> 20) & 1);
----------------
Please keep the leaf7 ECX bits with the others at line 1262. 


================
Comment at: lib/Target/X86/X86InstrSystem.td:506
+      def RDSSPQ : RI<0x1E, MRM1r, (outs GR64 : $dst), (ins GR64 : $src), "rdsspq\t$dst",
+                     [(set GR64 : $dst, (int_x86_rdsspq GR64 : $src))]>, XS, Requires<[In64BitMode]>;
+    }
----------------
Please limit lines to 80 columns.


Repository:
  rL LLVM

https://reviews.llvm.org/D40223